ifesdjeen commented on code in PR #3163:
URL: https://github.com/apache/cassandra/pull/3163#discussion_r1531823466
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -1296,5 +1296,6 @@ public static void log(Config config)
public volatile DurationSpec.LongMillisecondsBound
progress_barrier_timeout = new DurationSpec.LongMillisecondsBound("3600000ms");
public volatile DurationSpec.LongMillisecondsBound
progress_barrier_backoff = new DurationSpec.LongMillisecondsBound("1000ms");
+ public volatile DurationSpec.LongSecondsBound discovery_timeout = new
DurationSpec.LongSecondsBound("30s");
Review Comment:
Should we make this way higher by default, like 10 or even 30 minutes? I'm
just concenred that it is barely enough for a local sizeable cluster to start.
Maybe we should make it higher.
##########
src/java/org/apache/cassandra/tcm/ClusterMetadata.java:
##########
@@ -917,6 +1006,9 @@ public long serializedSize(ClusterMetadata metadata,
Version version)
size += ExtensionKey.serializer.serializedSize(entry.getKey(),
version) +
entry.getValue().serializedSize(version);
+ if (version.isAtLeast(Version.V2))
+ size +=
TypeSizes.sizeofUnsignedVInt(metadata.metadataIdentifier);;
Review Comment:
Two `;` in the end of line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
