ifesdjeen commented on code in PR #3060:
URL: https://github.com/apache/cassandra/pull/3060#discussion_r1531774105
##########
test/harry/main/org/apache/cassandra/harry/dsl/SingleOperationBuilder.java:
##########
@@ -36,8 +35,8 @@ public interface SingleOperationBuilder
* Insert _specific values_ into _specific_ row. Rows are ordered by
clustering key and
* numbered from 0 to maxRows
*/
- SingleOperationBuilder insert(int rowIdx, long[] vds);
- SingleOperationBuilder insert(int rowIdx, long[] vds, long[] sds);
+ SingleOperationBuilder insert(int rowIdx, int[] vds);
+ SingleOperationBuilder insert(int rowIdx, int[] vds, int[] sds);
Review Comment:
> Well, the inserts happen and the SUT matches, but validateAll() doesn't
like it :)
Could you elaborate a bit? `history.valueOverrides().override(column.name,
i, override);` is just used as a convenience method to quickly access override
generator.
But we do a swap of `Schema` in `HistoryBuilder` to make sure all child
generators are getting the correct (overriden) generators:
```
this.schema = schema.withCkGenerator(this.ckGenerator,
this.ckGenerator.columns)
.withColumns(valueHelper.regularColumns,
valueHelper.staticColumns);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
