sarankk commented on code in PR #102: URL: https://github.com/apache/cassandra-sidecar/pull/102#discussion_r1534410900
########## src/main/java/org/apache/cassandra/sidecar/metrics/instance/UploadSSTableComponentMetrics.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.metrics.instance; + +import java.util.Objects; + +import com.codahale.metrics.Meter; +import org.apache.cassandra.sidecar.metrics.NamedMetric; + +import static org.apache.cassandra.sidecar.metrics.instance.InstanceMetrics.INSTANCE_PREFIX; + +/** + * {@link UploadSSTableComponentMetrics} tracks metrics captured during upload of SSTable component into Sidecar. + */ +public class UploadSSTableComponentMetrics +{ + public static final String DOMAIN = INSTANCE_PREFIX + ".upload"; + protected final InstanceMetricRegistry instanceMetricRegistry; + public final String sstableComponent; + public final Meter rateLimitedCalls; + public final Meter diskUsageHighErrors; + + public UploadSSTableComponentMetrics(InstanceMetricRegistry instanceMetricRegistry, + String sstableComponent) + { + this.instanceMetricRegistry + = Objects.requireNonNull(instanceMetricRegistry, "Metric registry can not be null"); + this.sstableComponent + = Objects.requireNonNull(sstableComponent, "SSTable component required for component specific metrics capture"); + if (sstableComponent.isEmpty()) + { + throw new IllegalArgumentException("SSTableComponent required for component specific metrics capture"); + } + + NamedMetric.Tag componentTag = NamedMetric.Tag.of("component", sstableComponent); + + rateLimitedCalls + = NamedMetric.builder(instanceMetricRegistry::meter) + .withDomain(DOMAIN) + .withName("rate_limited_calls_429") + .addTag(componentTag) + .build().metric; + diskUsageHighErrors + = NamedMetric.builder(instanceMetricRegistry::meter) + .withDomain(DOMAIN) + .withName("disk_usage_high_errors") Review Comment: It is not the same currently. Code in upload handler to check if sufficient space is there, is different from `DiskprotectionHandler`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
