michaelsembwever commented on code in PR #2282:
URL: https://github.com/apache/cassandra/pull/2282#discussion_r1536823926
##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -360,8 +360,14 @@ public Builder()
{
}
- public TableParams build()
+ public TableParams build(String keyspace, String name)
{
+ if (compression == null)
+ if
(SchemaConstants.getLocalAndReplicatedSystemKeyspaceNames().contains(keyspace))
+ compression = CompressionParams.DEFAULT;
+ else
+ compression = CompressionParams.defaultParams();
+
Review Comment:
I believe this is resolved now …? @Claudenw
the keyspace name is always passed into the builders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]