Mmuzaf commented on code in PR #2852:
URL: https://github.com/apache/cassandra/pull/2852#discussion_r1545290659
##########
.build/run-python-dtests.sh:
##########
@@ -164,10 +165,13 @@ fi
# merge all unit xml files into one, and print summary test numbers
pushd ${CASSANDRA_DIR}/ >/dev/null
-# remove <testsuites> wrapping elements. `ant generate-unified-test-report`
doesn't like it`
+# remove <testsuites> wrapping elements. ant generate-test-report` doesn't
like it, and update testsuite name
sed -r "s/<[\/]?testsuites>//g" ${DIST_DIR}/test/output/nosetests.xml >
${TMPDIR}/nosetests.xml
cat ${TMPDIR}/nosetests.xml > ${DIST_DIR}/test/output/nosetests.xml
-ant -quiet -silent generate-unified-test-report
+sed "s/testsuite name=\"Cassandra dtests\"/testsuite
name=\"${DTEST_TARGET}_jdk${java_version}_python${python_version}_cython${cython}_$(uname
-m)${SPLIT_STRING}\"/g" ${DIST_DIR}/test/output/nosetests.xml >
${TMPDIR}/nosetests.xml
+cat ${TMPDIR}/nosetests.xml > ${DIST_DIR}/test/output/nosetests.xml
Review Comment:
Let's declare `${DIST_DIR}/test/output/` as a constant, it's used many times
throughout the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
