maedhroz commented on code in PR #3220:
URL: https://github.com/apache/cassandra/pull/3220#discussion_r1546768275
##########
src/java/org/apache/cassandra/cql3/statements/SelectStatement.java:
##########
@@ -973,10 +974,15 @@ private NavigableSet<Clustering<?>>
getRequestedRows(QueryOptions options, Clien
/**
* May be used by custom QueryHandler implementations
*/
- public RowFilter getRowFilter(QueryOptions options) throws
InvalidRequestException
+ public RowFilter getRowFilter(QueryOptions options, ClientState state)
throws InvalidRequestException
{
IndexRegistry indexRegistry = IndexRegistry.obtain(table);
- return restrictions.getRowFilter(indexRegistry, options);
+ RowFilter filter = restrictions.getRowFilter(indexRegistry, options);
+
+ if (filter.needsReconciliation() && filter.isMutableIntersection() &&
restrictions.needFiltering(table))
Review Comment:
I tried to order these checks from cheapest to most expensive. In this case,
it seemed avoiding the `needFiltering()` call when we don't even have a mutable
intersection seemed to make the most sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
