Claudenw commented on code in PR #3212:
URL: https://github.com/apache/cassandra/pull/3212#discussion_r1548090076
##########
test/unit/org/apache/cassandra/locator/PropertyFileSnitchTest.java:
##########
@@ -72,66 +72,95 @@ public void setup() throws ConfigurationException,
IOException
backupFile = Paths.get(confFile + ".bak");
localAddress = FBUtilities.getBroadcastAddressAndPort();
- restoreOrigConfigFile();
+ Files.copy(effectiveFile, backupFile,
java.nio.file.StandardCopyOption.REPLACE_EXISTING);
Review Comment:
Not for the `Files.copy` but for the `finally` of the try/catch that calls
`restoreOrigConfigFile()`. In fact `restoreOrigConfigFile` could be annotated
with `@After`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
