smiklosovic commented on code in PR #3210:
URL: https://github.com/apache/cassandra/pull/3210#discussion_r1555447454
##########
build.xml:
##########
@@ -710,9 +710,9 @@
<dependency groupId="com.google.j2objc"
artifactId="j2objc-annotations" version="1.3"/>
<!-- adding this dependency is necessary for assertj. When updating
assertj, need to also update the version of
this that the new assertj's `assertj-parent-pom` depends on. -->
- <dependency groupId="org.junit" artifactId="junit-bom"
version="5.6.0" type="pom" scope="test"/>
Review Comment:
I would be more comfortable with bumping this in a separate ticket rather
than burying it in a patch like this, for better visibility. Is is also
absolutely necessary to bump that or is this mostly an opportunistic "why not"
bump?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
