krummas commented on code in PR #3196:
URL: https://github.com/apache/cassandra/pull/3196#discussion_r1559787749
##########
src/java/org/apache/cassandra/tcm/sequences/RemoveNodeStreams.java:
##########
@@ -131,33 +131,12 @@ private static MovementMap movementMap(InetAddressAndPort
leaving, ClusterMetada
if (!replica.endpoint().equals(leaving)
&& !replica.endpoint().equals(newReplica.endpoint()))
candidateBuilder.add(replica,
ReplicaCollection.Builder.Conflict.NONE);
});
- movements.putAll(newReplica,
candidateBuilder.build(), ReplicaCollection.Builder.Conflict.NONE);
+ EndpointsForRange sources =
candidateBuilder.build();
+ // log if newReplica is an existing
transient replica moving to a full replica
Review Comment:
yep, almost - this became
```
if
(startWriteRemovals.get(newReplica.endpoint()).contains(newReplica.range(),
false))
logger.debug("Streaming transient -> full conversion to {} from {}",
newReplica, oldReplicas.get(newReplica.range()));
movements.put(oldReplicas.get(newReplica.range()), newReplica);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
