maedhroz commented on code in PR #3241:
URL: https://github.com/apache/cassandra/pull/3241#discussion_r1567689106
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -903,11 +903,18 @@ public static void setClientMode(boolean clientMode)
public volatile boolean zero_ttl_on_twcs_warned = true;
public volatile boolean zero_ttl_on_twcs_enabled = true;
public volatile boolean non_partition_restricted_index_query_enabled =
true;
- public volatile int sai_sstable_indexes_per_query_warn_threshold = 32;
- public volatile int sai_sstable_indexes_per_query_fail_threshold = -1;
public volatile boolean intersect_filtering_query_warned = true;
public volatile boolean intersect_filtering_query_enabled = true;
+ public volatile int sai_sstable_indexes_per_query_warn_threshold = 32;
+ public volatile int sai_sstable_indexes_per_query_fail_threshold = -1;
+ public volatile DataStorageSpec.LongBytesBound
sai_string_term_size_warn_threshold = new
DataStorageSpec.LongBytesBound("1KiB");
Review Comment:
I think @JeremiahDJordan's input counts for something here, given he's the
only one of us running SAI in production (in Astra). Also, if you look at this
patch from the perspective of what was here before, all I've done is take the
same (or even more lenient) max term sizes, and make sure writes fail visibly
for the client. This seems strictly better than silently compromising the index
with not so much as a warning.
The limits on term size before my patch here were derived at some point
during development at DS to protect the index, and I'm -100 on them being
opt-in, especially because they are brand new in 5.0 (as is SAI itself). I'm
more or less willing to die on this hill.
CC @mike-tr-adamson
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
