maedhroz commented on code in PR #3267:
URL: https://github.com/apache/cassandra/pull/3267#discussion_r1579775946
##########
src/java/org/apache/cassandra/db/memtable/Memtable.java:
##########
@@ -144,7 +143,7 @@ default boolean streamFromMemtable()
* Memtable metrics lifecycle matches table lifecycle. It is the table
that owns the metrics and
* decides when to release them.
*/
- default TableMetrics.ReleasableMetric
createMemtableMetrics(TableMetadataRef metadataRef)
+ default TrieMemtableMetricsView createMemtableMetrics(TableMetadataRef
metadataRef)
Review Comment:
It seems like we'd want to keep something like the `ReleasableMetric`
interface to keep details about particular implementations out of the
`Memtable` interface. What am I missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
