dcapwell commented on code in PR #3273:
URL: https://github.com/apache/cassandra/pull/3273#discussion_r1583400303
##########
src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java:
##########
@@ -556,6 +555,10 @@ public CQLStatement prepare(ClientState state)
checkFalse(prepared.hasConditions(),
NO_CONDITIONS_IN_UPDATES_MESSAGE, prepared.type, prepared.source);
checkFalse(prepared.isTimestampSet(),
NO_TIMESTAMPS_IN_UPDATES_MESSAGE, prepared.type, prepared.source);
+ for (ColumnMetadata column : prepared.updatedColumns())
Review Comment:
what if a reference is to a counter type?
```
LET a = (select counter from tbl where pk=?);
IF a.counter > 10 THEN
...
END IF
```
##########
test/unit/org/apache/cassandra/cql3/statements/TransactionStatementTest.java:
##########
@@ -33,13 +33,7 @@
import org.apache.cassandra.transport.messages.ResultMessage;
import org.assertj.core.api.Assertions;
-import static
org.apache.cassandra.cql3.statements.TransactionStatement.DUPLICATE_TUPLE_NAME_MESSAGE;
-import static
org.apache.cassandra.cql3.statements.TransactionStatement.EMPTY_TRANSACTION_MESSAGE;
-import static
org.apache.cassandra.cql3.statements.TransactionStatement.ILLEGAL_RANGE_QUERY_MESSAGE;
-import static
org.apache.cassandra.cql3.statements.TransactionStatement.INCOMPLETE_PRIMARY_KEY_SELECT_MESSAGE;
-import static
org.apache.cassandra.cql3.statements.TransactionStatement.NO_CONDITIONS_IN_UPDATES_MESSAGE;
-import static
org.apache.cassandra.cql3.statements.TransactionStatement.NO_TIMESTAMPS_IN_UPDATES_MESSAGE;
-import static
org.apache.cassandra.cql3.statements.TransactionStatement.SELECT_REFS_NEED_COLUMN_MESSAGE;
+import static org.apache.cassandra.cql3.statements.TransactionStatement.*;
Review Comment:
can you revert? `*` isn't desired in our style guides
##########
src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java:
##########
@@ -84,9 +84,7 @@
import static accord.primitives.Txn.Kind.EphemeralRead;
import static accord.primitives.Txn.Kind.Read;
-import static
org.apache.cassandra.cql3.statements.RequestValidations.checkFalse;
-import static
org.apache.cassandra.cql3.statements.RequestValidations.checkNotNull;
-import static
org.apache.cassandra.cql3.statements.RequestValidations.checkTrue;
+import static org.apache.cassandra.cql3.statements.RequestValidations.*;
Review Comment:
can you revert? We don't like `*` in our style guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
