ekaterinadimitrova2 commented on code in PR #259:
URL: https://github.com/apache/cassandra-dtest/pull/259#discussion_r1583851604
##########
cql_test.py:
##########
@@ -1219,12 +1219,6 @@ def _assert_logs_slow_queries_with_skinny_table(node,
session):
TestCQLSlowQuery._assert_logs(node, session, table,
query="SELECT * FROM {} WHERE k >= 0 AND
k < 100 ALLOW FILTERING",
logged_query="SELECT \* FROM ks.{} WHERE
k >= 0 AND k < 100")
- TestCQLSlowQuery._assert_logs(node, session, table,
- query="SELECT * FROM {} WHERE k <= 100
AND k > 0 ALLOW FILTERING",
- logged_query="SELECT \* FROM ks.{} WHERE
k > 0 AND k <= 100")
- TestCQLSlowQuery._assert_logs(node, session, table,
- query="SELECT * FROM {} WHERE k < 100
AND k >= 0 ALLOW FILTERING",
- logged_query="SELECT \* FROM ks.{} WHERE
k >= 0 AND k < 100")
Review Comment:
```
if node.cluster.version() >= '5.1':
TestCQLSlowQuery._assert_logs(node, session, table,
query="SELECT * FROM {} WHERE k <=
100 AND k > 0 ALLOW FILTERING",
logged_query="SELECT \* FROM ks.{}
WHERE k <= 100 AND k > 0")
TestCQLSlowQuery._assert_logs(node, session, table,
query="SELECT * FROM {} WHERE k <
100 AND k >= 0 ALLOW FILTERING",
logged_query="SELECT \* FROM ks.{}
WHERE k < 100 AND k >= 0")
else:
TestCQLSlowQuery._assert_logs(node, session, table,
query="SELECT * FROM {} WHERE k <=
100 AND k > 0 ALLOW FILTERING",
logged_query="SELECT \* FROM ks.{}
WHERE k > 0 AND k <= 100")
TestCQLSlowQuery._assert_logs(node, session, table,
query="SELECT * FROM {} WHERE k <
100 AND k >= 0 ALLOW FILTERING",
logged_query="SELECT \* FROM ks.{}
WHERE k >= 0 AND k < 100")
```
This passes for me both with your patch and plain 5.0 branch.
##########
json_test.py:
##########
@@ -1238,38 +1238,6 @@ def test_simple_schema(self):
"""
run_func_docstring(tester=self, test_func=self.test_simple_schema)
- def test_pkey_requirement(self):
Review Comment:
I saw you added respective unit test in the cassandra repo. We should either
backport that test to previous versions too or we should keep this one up to
5.0.
Something like this - `@since("2.2", max_version="4.X")`. and port the
cassandra test only to 5.0 maybe?
We can say up to 5.0 but then it won't test probably patch versions of 5.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
