aweisberg commented on code in PR #3280:
URL: https://github.com/apache/cassandra/pull/3280#discussion_r1585237469
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -3993,7 +3993,7 @@ protected synchronized void drain(boolean
isFinalShutdown) throws IOException, I
CommitLog.instance.shutdownBlocking();
// wait for miscellaneous tasks like sstable and commitlog segment
deletion
- ColumnFamilyStore.shutdownPostFlushExecutor();
+ ColumnFamilyStore.awaitPendingFlushes();
Review Comment:
I am concerned that this might get stuck waiting pending flushes and then
never actually finish because the executors or components that might finish
them never get to run. Need to check this when I get back to working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
