krummas commented on code in PR #3245:
URL: https://github.com/apache/cassandra/pull/3245#discussion_r1587687697
##########
src/java/org/apache/cassandra/net/Verb.java:
##########
@@ -224,11 +224,11 @@ public enum Verb
PAXOS2_CLEANUP_COMPLETE_REQ (48, P2, repairTimeout, PAXOS_REPAIR,
() -> PaxosCleanupComplete.serializer, () ->
PaxosCleanupComplete.verbHandler,
PAXOS2_CLEANUP_COMPLETE_RSP ),
// transactional cluster metadata
- TCM_COMMIT_RSP (801, P1, rpcTimeout, INTERNAL_METADATA,
MessageSerializers::commitResultSerializer, () ->
ResponseVerbHandler.instance ),
- TCM_COMMIT_REQ (802, P1, rpcTimeout, INTERNAL_METADATA,
MessageSerializers::commitSerializer, () ->
commitRequestHandler(), TCM_COMMIT_RSP ),
- TCM_FETCH_CMS_LOG_RSP (803, P1, rpcTimeout, FETCH_LOG,
MessageSerializers::logStateSerializer, () ->
ResponseVerbHandler.instance ),
- TCM_FETCH_CMS_LOG_REQ (804, P1, rpcTimeout, FETCH_LOG, ()
-> FetchCMSLog.serializer, () ->
fetchLogRequestHandler(), TCM_FETCH_CMS_LOG_RSP ),
- TCM_REPLICATION (805, P1, rpcTimeout, INTERNAL_METADATA,
MessageSerializers::logStateSerializer, () -> replicationHandler()
),
+ TCM_COMMIT_RSP (801, P0, rpcTimeout, INTERNAL_METADATA,
MessageSerializers::commitResultSerializer, () ->
ResponseVerbHandler.instance ),
+ TCM_COMMIT_REQ (802, P0, rpcTimeout, INTERNAL_METADATA,
MessageSerializers::commitSerializer, () ->
commitRequestHandler(), TCM_COMMIT_RSP ),
+ TCM_FETCH_CMS_LOG_RSP (803, P0, rpcTimeout, FETCH_LOG,
MessageSerializers::logStateSerializer, () ->
ResponseVerbHandler.instance ),
+ TCM_FETCH_CMS_LOG_REQ (804, P0, rpcTimeout, FETCH_LOG, ()
-> FetchCMSLog.serializer, () ->
fetchLogRequestHandler(), TCM_FETCH_CMS_LOG_RSP ),
+ TCM_REPLICATION (805, P0, rpcTimeout, INTERNAL_METADATA,
MessageSerializers::logStateSerializer, () -> replicationHandler()
),
TCM_NOTIFY_RSP (806, P1, rpcTimeout, INTERNAL_METADATA, ()
-> Epoch.messageSerializer, () ->
ResponseVerbHandler.instance ),
Review Comment:
we should probably raise the priority of all TCM messages to P0
##########
src/java/org/apache/cassandra/service/paxos/PaxosCommit.java:
##########
@@ -175,9 +175,12 @@ static <T extends Consumer<Status>> T commit(Agreed
commit, Participants partici
void start(Participants participants, boolean async)
{
boolean executeOnSelf = false;
- Message<Agreed> commitMessage = Message.out(PAXOS_COMMIT_REQ, commit);
- Message<Mutation> mutationMessage = ENABLE_DC_LOCAL_COMMIT &&
consistencyForConsensus.isDatacenterLocal()
- ?
Message.out(PAXOS2_COMMIT_REMOTE_REQ, commit.makeMutation()) : null;
+ boolean isUrgent =
participants.keyspace.getMetadata().params.replication.isMeta();
Review Comment:
maybe extract this in to a `participants.isUrgent()` method to avoid
duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
