maedhroz commented on code in PR #3095:
URL: https://github.com/apache/cassandra/pull/3095#discussion_r1588600576
##########
src/java/org/apache/cassandra/cql3/restrictions/RestrictionSetWrapper.java:
##########
@@ -54,25 +52,26 @@ public void addToRowFilter(RowFilter filter,
restrictions.addToRowFilter(filter, indexRegistry, options);
}
- public List<ColumnMetadata> getColumnDefs()
+ public List<ColumnMetadata> columns()
{
- return restrictions.getColumnDefs();
+ return restrictions.columns();
}
- @Override
- public Collection<ColumnMetadata> getColumnDefinitions()
Review Comment:
I know `getColumnDefinitions()` looks like a duplicate, but I think it was
added in CASSANDRA-18155 explicitly to avoid defensive copying the `keySet()`
in `RestrictionSet`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
