maedhroz commented on code in PR #3274:
URL: https://github.com/apache/cassandra/pull/3274#discussion_r1591599236
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -2238,6 +2247,91 @@ public static long getMinRpcTimeout(TimeUnit unit)
getTruncateRpcTimeout(unit));
}
+ public static Config.CQLStartTime getCQLStartTime()
+ {
+ return conf.cql_start_time;
+ }
+
+ public static void setCQLStartTime(Config.CQLStartTime value)
+ {
+ conf.cql_start_time = value;
+ }
+
+ /**
+ * How much time the item is allowed to spend in (currently only Native)
queue, compared to {@link #nativeTransportIdleTimeout()},
+ * before backpressure starts being applied.
+ *
+ * For example, setting this value to 0.5 means and having the largest of
read/range/write/counter timeouts to 10 seconds
+ * means that if any item spends more than 5 seconds in the queue,
backpressure will be applied to the socket associated
+ * with this queue.
+ *
+ * Set to 0 or any negative value to fully disable.
+ */
+ public static double getNativeTransportQueueMaxItemAgeThreshold()
+ {
+ return conf.native_transport_queue_max_item_age_threshold;
+ }
+
+ public static void setNativeTransportMaxQueueItemAgeThreshold(double
threshold)
+ {
+ conf.native_transport_queue_max_item_age_threshold = threshold;
+ }
+
+ public static long getNativeTransportMinBackoffOnQueueOverload(TimeUnit
timeUnit)
+ {
+ return
conf.native_transport_min_backoff_on_queue_overload.to(timeUnit);
+ }
+
+ public static long getNativeTransportMaxBackoffOnQueueOverload(TimeUnit
timeUnit)
+ {
+ return
conf.native_transport_max_backoff_on_queue_overload.to(timeUnit);
+ }
+
+ public static void setNativeTransportBackoffOnQueueOverload(long
minBackoffMillis,
+ long
maxBackoffMillis,
+ TimeUnit
timeUnit)
+ {
+ if (minBackoffMillis <= 0)
+ throw new IllegalArgumentException("Min backoff on queue overload
should be positive");
+
+ if (minBackoffMillis >= maxBackoffMillis)
+ throw new IllegalArgumentException(String.format("Max backoff on
queue overload should be greater than min backoff, but %s >= %s",
minBackoffMillis, maxBackoffMillis));
+
+
+ conf.native_transport_min_backoff_on_queue_overload = new
DurationSpec.LongMillisecondsBound(minBackoffMillis, timeUnit);
+ conf.native_transport_max_backoff_on_queue_overload = new
DurationSpec.LongMillisecondsBound(maxBackoffMillis, timeUnit);
Review Comment:
nit: I'm still not entirely sure if these need to be `volatile`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
