dcapwell commented on code in PR #3293:
URL: https://github.com/apache/cassandra/pull/3293#discussion_r1594310904
##########
src/java/org/apache/cassandra/config/AccordSpec.java:
##########
@@ -71,4 +73,62 @@ public enum TransactionalRangeMigration
public TransactionalMode default_transactional_mode =
TransactionalMode.off;
public boolean ephemeralReadEnabled = false;
public boolean state_cache_listener_jfr_enabled = true;
+ public final JournalSpec journal = new JournalSpec();
+
+ public static class JournalSpec implements Params
+ {
+ public int segmentSize = 32 << 20;
+ public FailurePolicy failurePolicy = FailurePolicy.STOP;
+ public FlushMode flushMode = FlushMode.BATCH;
+ public DurationSpec.IntMillisecondsBound flushPeriod; // pulls default
from 'commitlog_sync_period'
+ public DurationSpec.IntMillisecondsBound periodicFlushLagBlock = new
DurationSpec.IntMillisecondsBound("1500ms");
+
+ @Override
+ public int segmentSize()
+ {
+ return segmentSize;
+ }
+
+ @Override
+ public FailurePolicy failurePolicy()
+ {
+ return failurePolicy;
+ }
+
+ @Override
+ public FlushMode flushMode()
+ {
+ return flushMode;
+ }
+
+ @JsonIgnore
+ @Override
+ public int flushPeriodMillis()
+ {
+ return flushPeriod == null ?
DatabaseDescriptor.getCommitLogSyncPeriod()
+ : flushPeriod.toMilliseconds();
+ }
+
+ @JsonIgnore
Review Comment:
I think this isn't needed as `get` is needed for it to be picked up... I was
just trying to be explicit...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
