beobal commented on code in PR #3297:
URL: https://github.com/apache/cassandra/pull/3297#discussion_r1596330187
##########
src/java/org/apache/cassandra/dht/IPartitionerDependentSerializer.java:
##########
@@ -51,11 +41,8 @@ public interface IPartitionerDependentSerializer<T>
*/
public T deserialize(DataInputPlus in, IPartitioner p, int version) throws
IOException;
- /**
- * Calculate serialized size of object without actually serializing.
- * @param t object to calculate serialized size
- * @param version protocol version
- * @return serialized size of object t
- */
- public long serializedSize(T t, int version);
+ default T deserialize(DataInputPlus in, int version) throws IOException
+ {
+ return deserialize(in, null, version);
Review Comment:
Would it make more sense to default to `IPartitioner.global`, rather than
`null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
