ifesdjeen commented on code in PR #3288:
URL: https://github.com/apache/cassandra/pull/3288#discussion_r1598052747
##########
src/java/org/apache/cassandra/tcm/RemoteProcessor.java:
##########
@@ -152,34 +150,37 @@ public ClusterMetadata fetchLogAndWait(Epoch waitFor,
Retry.Deadline retryPolicy
public static ClusterMetadata fetchLogAndWait(CandidateIterator
candidateIterator, LocalLog log)
{
- Promise<LogState> remoteRequest = new AsyncPromise<>();
- return fetchLogAndWaitInternal(remoteRequest, candidateIterator, log);
+ try
+ {
+ return fetchLogAndWaitInternal(candidateIterator,
log).awaitUninterruptibly().get();
Review Comment:
Do you mean `await` with a timeout, or without? My logic for doing it this
way was that we will rely on messaging service timeouts now to time this one
out, so it should never be indefinite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
