xvade commented on code in PR #3301:
URL: https://github.com/apache/cassandra/pull/3301#discussion_r1599243523
##########
src/java/org/apache/cassandra/cql3/Operator.java:
##########
@@ -266,6 +266,59 @@ public boolean canBeUsedWith(ColumnsExpression.Kind kind)
return kind != ColumnsExpression.Kind.MAP_ELEMENT;
}
},
+ BETWEEN(16)
Review Comment:
> I am wondering why `BETWEEN(16)` is not after 15?
It seemed that the convention in Operator.java was not super strict about
ordering operations numerically, and so I opted to put it with the slices
because that seemed like a fitting way of ordering in lieu of by index. It
would also make a ton of sense to put it after 15, but I'd be inclined to
reorder or renumber the rest of the file to fit the numbering convention if we
did that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
