iamaleksey commented on code in PR #88:
URL: https://github.com/apache/cassandra-accord/pull/88#discussion_r1599850942
##########
accord-core/src/main/java/accord/coordinate/CoordinateTransaction.java:
##########
@@ -84,7 +86,7 @@ void onPreAccepted(Topologies topologies, Timestamp
executeAt, List<PreAcceptOk>
// but by sending accept we rule
out hybrid fast-path
// TODO (low priority, efficiency): if we receive an expired
response, perhaps defer to permit at least one other
// node to respond before
invalidating
- if (executeAt.isRejected() || node.agent().isExpired(txnId,
executeAt.hlc()))
+ if (executeAt.isRejected() || executeAt.hlc() - txnId.hlc() >=
node.agent().preAcceptTimeout(MICROSECONDS))
Review Comment:
Good point indeed. And it's actually trivially fixed and looks a bit simpler
once addressed. Pushed and update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
