dcapwell commented on code in PR #3305:
URL: https://github.com/apache/cassandra/pull/3305#discussion_r1602294877
##########
src/java/org/apache/cassandra/db/virtual/AccordVirtualTables.java:
##########
@@ -73,6 +79,43 @@ public DataSet data()
}
}
+ public static final class CommandStoreCache extends AbstractVirtualTable
+ {
+ private CommandStoreCache(String keyspace)
+ {
+ super(parse(keyspace,
+ "Accord Command Store Cache Metrics",
+ "CREATE TABLE accord_command_store_cache(\n" +
+ " id int,\n" +
+ " queries bigint,\n" +
Review Comment:
one issue with this table is it uses the global stats and not the instance
stats... I kinda feel we should expose both?
What I see in practice is that `commands` and `commandsForKeys` have very
different cache hit stats and the global is showing it for all... If you look
at the patch I did to add JFR support I show the stats per instance with a
label so we know where its coming from... that helps show if commands are
getting flushed out constantly in favor of CFK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
