dcapwell commented on code in PR #90:
URL: https://github.com/apache/cassandra-accord/pull/90#discussion_r1605538447
##########
accord-core/src/test/java/accord/impl/basic/DelayedCommandStores.java:
##########
@@ -266,22 +265,14 @@ public DelayedSafeStore(DelayedCommandStore commandStore,
RangesForEpoch ranges,
@Override
public void postExecute()
{
- if (context instanceof Message)
Review Comment:
not related to this patch... I added this logic to detect mutations outside
of types with side effects, but really we should check that we can still load
the command that we are trying to write... this makes sure that we don't bias
towards only checking for txn we re-load
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
