Claudenw commented on code in PR #3330:
URL: https://github.com/apache/cassandra/pull/3330#discussion_r1620523975


##########
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java:
##########
@@ -697,10 +698,10 @@ public void testAlterTableWithCompression() throws 
Throwable
         createTable("CREATE TABLE %s (a text, b int, c int, primary key (a, 
b))");
         assertSchemaOption("compression", map("chunk_length_in_kb", "16", 
"class", "org.apache.cassandra.io.compress.LZ4Compressor"));
 
-        alterTable("ALTER TABLE %s WITH compression = { 'class' : 
'SnappyCompressor', 'chunk_length_in_kb' : 32 };");
+        alterTable("ALTER TABLE %s WITH compression = { 'class' : 
'SnappyCompressor', 'chunk_length' : '32KiB' };");
         assertSchemaOption("compression", map("chunk_length_in_kb", "32", 
"class", "org.apache.cassandra.io.compress.SnappyCompressor"));
 
-        alterTable("ALTER TABLE %s WITH compression = { 'class' : 
'LZ4Compressor', 'chunk_length_in_kb' : 64 };");
+        alterTable("ALTER TABLE %s WITH compression = { 'class' : 
'LZ4Compressor', 'chunk_length' : '64KiB' };");

Review Comment:
    @smiklosovic  Here is an example of `chunk_length` as in CQL. It looks like 
you can use "chunk_length" : 35KiB much the same as you can use 
chunk_length_in_kb : 35 but chunk_length is not documented as a CQL option in 
the user documentation. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to