samueldlightfoot commented on code in PR #3348:
URL: https://github.com/apache/cassandra/pull/3348#discussion_r1627274338
##########
src/java/org/apache/cassandra/cql3/restrictions/SimpleRestriction.java:
##########
@@ -225,17 +226,22 @@ public void restrict(RangeSet<ClusteringElements>
rangeSet, QueryOptions options
private List<ClusteringElements> bindAndGetClusteringElements(QueryOptions
options)
{
+ List<ClusteringElements> elements = new ArrayList<>();
Review Comment:
A good point. I had assumed the exception creation cost would dwarf list
creation. I have tidied this up.
Interesting idea on the empty element checks -- I'd have to do some digging
on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
