blerer commented on code in PR #3359:
URL: https://github.com/apache/cassandra/pull/3359#discussion_r1634834755
##########
test/unit/org/apache/cassandra/cql3/conditions/ColumnConditionTest.java:
##########
@@ -246,88 +249,100 @@ private static List<ByteBuffer> list(ByteBuffer...
values)
public void testListCollectionBoundAppliesTo() throws
InvalidRequestException
{
// EQ
- assertTrue(conditionApplies(list(ONE), EQ, list(ONE)));
- assertTrue(conditionApplies(list(), EQ, list()));
- assertFalse(conditionApplies(list(ONE), EQ, list(ZERO)));
- assertFalse(conditionApplies(list(ZERO), EQ, list(ONE)));
- assertFalse(conditionApplies(list(ONE, ONE), EQ, list(ONE)));
- assertFalse(conditionApplies(list(ONE), EQ, list(ONE, ONE)));
- assertFalse(conditionApplies(list(ONE), EQ, list()));
- assertFalse(conditionApplies(list(), EQ, list(ONE)));
-
- assertFalse(conditionApplies(list(ONE), EQ,
list(ByteBufferUtil.EMPTY_BYTE_BUFFER)));
- assertFalse(conditionApplies(list(ByteBufferUtil.EMPTY_BYTE_BUFFER),
EQ, list(ONE)));
- assertTrue(conditionApplies(list(ByteBufferUtil.EMPTY_BYTE_BUFFER),
EQ, list(ByteBufferUtil.EMPTY_BYTE_BUFFER)));
+ assertTrue(appliesListCondition(list(ONE), EQ, list(ONE)));
+ assertTrue(appliesListCondition(null, EQ, null));
+ assertTrue(appliesListCondition(null, EQ, list()));
+ assertFalse(appliesListCondition(list(ONE), EQ, list(ZERO)));
+ assertFalse(appliesListCondition(list(ZERO), EQ, list(ONE)));
+ assertFalse(appliesListCondition(list(ONE, ONE), EQ, list(ONE)));
+ assertFalse(appliesListCondition(list(ONE), EQ, list(ONE, ONE)));
+ assertFalse(appliesListCondition(list(ONE), EQ, null));
+ assertFalse(appliesListCondition(list(ONE), EQ, list()));
+ assertFalse(appliesListCondition(null, EQ, list(ONE)));
Review Comment:
In practice, you will never get an empty collection returned from a row for
a multi-cell collection. It will always be `null`. Which is why testing it
does not make any sense and is in fact more confusing than anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
