dcapwell commented on code in PR #3379:
URL: https://github.com/apache/cassandra/pull/3379#discussion_r1645026476
##########
src/java/org/apache/cassandra/net/Verb.java:
##########
@@ -335,8 +335,8 @@ public enum Verb
ACCORD_GET_EPHMRL_READ_DEPS_REQ (162, P2, writeTimeout, IMMEDIATE,
() -> GetEphmrlReadDepsSerializers.request, AccordService::verbHandlerOrNoop,
ACCORD_GET_EPHMRL_READ_DEPS_RSP),
ACCORD_GET_MAX_CONFLICT_RSP (163, P2, writeTimeout, IMMEDIATE,
() -> GetMaxConflictSerializers.reply, RESPONSE_HANDLER
),
ACCORD_GET_MAX_CONFLICT_REQ (164, P2, writeTimeout, IMMEDIATE,
() -> GetMaxConflictSerializers.request, AccordService::verbHandlerOrNoop,
ACCORD_GET_MAX_CONFLICT_RSP),
- ACCORD_FETCH_DATA_RSP (145, P2, repairTimeout,IMMEDIATE,
() -> FetchSerializers.reply, RESPONSE_HANDLER
),
- ACCORD_FETCH_DATA_REQ (146, P2, repairTimeout,IMMEDIATE,
() -> FetchSerializers.request, AccordService::verbHandlerOrNoop,
ACCORD_FETCH_DATA_RSP ),
+ ACCORD_FETCH_DATA_RSP (145, P2, writeTimeout,IMMEDIATE,
() -> FetchSerializers.reply, RESPONSE_HANDLER
),
Review Comment:
spoke with @bdeggleston about this in slack, this timeout is too large and
using an unrelated config (bootstrap and repair are not the same thing). This
isn't 100% related to this patch as its from my topology fix patch, but trying
to pull out bug fixes to make reviews easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
