krummas commented on code in PR #3375:
URL: https://github.com/apache/cassandra/pull/3375#discussion_r1650406359
##########
src/java/org/apache/cassandra/tcm/ClusterMetadataService.java:
##########
@@ -373,6 +373,20 @@ public void reconfigureCMS(ReplicationParams
replicationParams)
InProgressSequences.finishInProgressSequences(ReconfigureCMS.SequenceKey.instance);
}
+ public void maybeReconfigureCMS(ClusterMetadata metadata)
+ {
+ try
+ {
+ if (PrepareCMSReconfiguration.needsReconfiguration(metadata))
+ reconfigureCMS(ReplicationParams.meta(metadata));
Review Comment:
yeah either way I think we're good here - if the reconfiguration fails we'll
alert the operator via metrics and `nodetool cms`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
