aweisberg commented on code in PR #3391:
URL: https://github.com/apache/cassandra/pull/3391#discussion_r1679713956
##########
test/unit/org/apache/cassandra/service/WriteResponseHandlerTest.java:
##########
@@ -153,17 +154,23 @@ public void idealCLLatencyTracked() throws Throwable
//dc1
awr.onResponse(createDummyMessage(0));
awr.onResponse(createDummyMessage(1));
+
+ // there are no enough responses for ideal EACH_QUORUM yet
Review Comment:
```suggestion
// there are not enough responses for ideal EACH_QUORUM yet
```
##########
src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java:
##########
@@ -280,6 +289,8 @@ public void onFailure(InetAddressAndPort from,
RequestFailureReason failureReaso
failureReasonByEndpoint.put(from, failureReason);
+ logFailureOrTimeoutToIdealCLDelegate();
Review Comment:
Ouch looks like the failure path didn't decrement at all before?
I guess the only reason it gave some signal was because we would call
expired explicitly if gossip thought the endpoint was down so it would be a
non-zero metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
