dcapwell commented on code in PR #3416:
URL: https://github.com/apache/cassandra/pull/3416#discussion_r1680113576
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -688,6 +866,182 @@ public Id nodeId()
return node.id();
}
+ @Nullable
+ @Override
+ public Long minEpoch(Collection<TokenRange> ranges)
+ {
+ return node.topology().minEpoch();
+// TxnId txnId = node.nextTxnId(Kind.ExclusiveSyncPoint,
Routable.Domain.Range);
Review Comment:
yes, cleanup is desired here...
so, I tried to find the smallest epoch we still cared about, but the logic
kept failing. Talking with @belliottsmith he said to just use `minEpoch`...
This works just fine, but right now we don't *purge* older epochs... there is a
ticket for that... right now epochs grow and grow and grow... we do know when
an epoch is redundant (all txn in that epoch have executed) so we could always
purge... we just need to do that =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
