dcapwell commented on code in PR #3413: URL: https://github.com/apache/cassandra/pull/3413#discussion_r1681563804
########## test/unit/org/apache/cassandra/cql3/statements/TransactionStatementTest.java: ########## @@ -33,14 +33,7 @@ import org.apache.cassandra.transport.messages.ResultMessage; import org.assertj.core.api.Assertions; -import static org.apache.cassandra.cql3.statements.TransactionStatement.DUPLICATE_TUPLE_NAME_MESSAGE; -import static org.apache.cassandra.cql3.statements.TransactionStatement.EMPTY_TRANSACTION_MESSAGE; -import static org.apache.cassandra.cql3.statements.TransactionStatement.ILLEGAL_RANGE_QUERY_MESSAGE; -import static org.apache.cassandra.cql3.statements.TransactionStatement.INCOMPLETE_PRIMARY_KEY_SELECT_MESSAGE; -import static org.apache.cassandra.cql3.statements.TransactionStatement.NO_CONDITIONS_IN_UPDATES_MESSAGE; -import static org.apache.cassandra.cql3.statements.TransactionStatement.NO_COUNTERS_IN_TXNS_MESSAGE; -import static org.apache.cassandra.cql3.statements.TransactionStatement.NO_TIMESTAMPS_IN_UPDATES_MESSAGE; -import static org.apache.cassandra.cql3.statements.TransactionStatement.SELECT_REFS_NEED_COLUMN_MESSAGE; +import static org.apache.cassandra.cql3.statements.TransactionStatement.*; Review Comment: https://cassandra.apache.org/_/development/code_style.html is what defines our style, but it overrides https://www.oracle.com/java/technologies/javase/codeconventions-fileorganization.htm In both cases I don't see this documented... so I think we only approved moving away from `.*` in a mailing list thread and didn't update our guides? Sorry about that =( The only place that hits at that is `ide/idea/codeStyleSettings.xml` which makes it 100 elements before we replace with `.*` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
