dcapwell commented on code in PR #3416:
URL: https://github.com/apache/cassandra/pull/3416#discussion_r1683344146
##########
src/java/org/apache/cassandra/tcm/Startup.java:
##########
@@ -365,21 +367,29 @@ public static void startup(Supplier<Transformation>
initialTransformation, boole
{
ClusterMetadata metadata = ClusterMetadata.current();
NodeId self = metadata.myNodeId();
- AccordService.startup(self);
// finish in-progress sequences first
InProgressSequences.finishInProgressSequences(self);
metadata = ClusterMetadata.current();
- switch (metadata.directory.peerState(self))
+ NodeState startingstate = metadata.directory.peerState(self);
+ switch (startingstate)
+ {
+ case REGISTERED:
+ case LEFT:
+ break;
+ default:
+ AccordService.startup(self);
+ }
+ switch (startingstate)
Review Comment:
@ifesdjeen I tried to document this.
```
// When Accord starts up it needs to check for any historic epochs that it
needs to know about (in order
// to handle pending transactions), in order to know what nodes to check
with it needs to know what the
// settled placement is (so it knows what peers to reach out to).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
