maedhroz commented on code in PR #3350:
URL: https://github.com/apache/cassandra/pull/3350#discussion_r1685233274
##########
src/java/org/apache/cassandra/index/IndexStatusManager.java:
##########
@@ -84,26 +85,39 @@ private IndexStatusManager()
*/
public <E extends Endpoints<E>> E filterForQuery(E liveEndpoints, Keyspace
keyspace, Index.QueryPlan indexQueryPlan, ConsistencyLevel level)
Review Comment:
`contactForRead()` just generates a sub-list from left to right, so that
should work. In most cases, the sort shouldn't even happen, as `UNKNOWN` states
should be transient/rare. Since the number of nodes in this state should very
small, and we may have a large cluster, I'd also make the initial size of
`queryableNonSucceeded` something reasonably small, like 4 (w/ a comment), or
even use the default (16). With the `ReplicaCollection.Builder` it made sense
to do the opposite, but that, in retrospect, would not have been very nice
either in a large cluster with most things built/succeeded (aside from avoiding
resizing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
