smiklosovic commented on code in PR #3374:
URL: https://github.com/apache/cassandra/pull/3374#discussion_r1686165321
##########
test/unit/org/apache/cassandra/service/snapshot/TableSnapshotTest.java:
##########
@@ -298,7 +298,7 @@ public void testShouldClearSnapshot() throws Exception
// 1. snapshot to clear is not ephemeral
// 2. tag to clear is null, empty, or it is equal to snapshot
tag
// 3. byTimestamp is true
- if (TableSnapshot.shouldClearSnapshot(testingTag,
olderThanTimestamp).test(snapshot))
+ if (SnapshotManager.shouldClearSnapshot(testingTag,
Set.of(keyspace), olderThanTimestamp, false).test(snapshot))
Review Comment:
I think this is just fine. `shouldClearSnapshot` method indeed accepts
keyspace now, but the logic in it takes into account the situation when a
keyspaces set is empty, preserving the original behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
