dcapwell commented on code in PR #3441:
URL: https://github.com/apache/cassandra/pull/3441#discussion_r1692183967
##########
test/simulator/main/org/apache/cassandra/simulator/harry/HarryValidatingQuery.java:
##########
@@ -137,9 +138,8 @@ protected Object[][] executeNodeLocal(String statement,
TokenPlacementModel.Node
catch (Throwable t)
{
logger.error("Caught an exception while validating", t);
Review Comment:
> suppressed error
why would we want to suppress? Something unexpected happened and we have no
clue how to handle... so we should fail the test. This might be the
`AssertError` we now generate, but we have to push that up... but what if its a
different error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
