maedhroz commented on code in PR #3426:
URL: https://github.com/apache/cassandra/pull/3426#discussion_r1702045637
##########
src/java/org/apache/cassandra/tcm/serialization/Version.java:
##########
@@ -37,6 +37,7 @@ public enum Version
* - Added version to PlacementForRange serializer
* - Serialize MemtableParams when serializing TableParams
* - Added AccordFastPath
+ * - Added StaleReplicas
Review Comment:
So `AccordFastPath`, `ConsensusMigrationState`, and `StaleReplicas` are all
new in `cep-15-accord`. Should we, before merging to trunk, assign them to a
new V3, update `CURRENT_METADATA_VERSION`, and revisit any conditionals we have
in `Serializer` implementations? Stuff like...
```
if (version.isAtLeast(V2))
{
AccordFastPath.serializer.serialize(metadata.accordFastPath, out,
version);
ConsensusMigrationState.serializer.serialize(metadata.consensusMigrationState,
out, version);
StaleReplicas.serializer.serialize(metadata.staleReplicas, out, version);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
