maedhroz commented on code in PR #3442:
URL: https://github.com/apache/cassandra/pull/3442#discussion_r1707433955
##########
src/java/org/apache/cassandra/tcm/transformations/cms/PrepareCMSReconfiguration.java:
##########
@@ -215,6 +215,9 @@ public long serializedSize(Transformation t, Version
version)
public static Diff diff(Set<NodeId> currentCms, Set<NodeId> newCms)
{
+ assert !currentCms.contains(null);
+ assert !newCms.contains(null);
Review Comment:
nit: Could throw error messages in here, but it's not like we'd gain much
information from that in debugging, unless we wanted to know what the rest of
the nodes in the sets are as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
