belliottsmith commented on code in PR #109:
URL: https://github.com/apache/cassandra-accord/pull/109#discussion_r1709416617
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -1249,193 +1198,94 @@ private static ProgressShard progressShard(Route<?>
route, @Nullable RoutingKey
return progressKey.equals(route.homeKey()) ? Home : Local;
}
- enum EnsureAction
- {
- /** Don't check */
- Ignore,
- /** Add, but return false if insufficient for any reason */
- TryAdd,
- /** Supplement existing information, asserting that the existing and
additional information are independently sufficient,
- * returning false only if the existing information is absent AND the
new information is insufficient. */
- Add,
- /** Set, but only return false if insufficient */
- TrySet,
- /** Overwrite existing information if sufficient; fail otherwise */
- Set
- }
-
@SuppressWarnings({"unchecked", "rawtypes"})
- private static CommonAttributes set(CommonAttributes attrs,
- Ranges existingRanges, Ranges
additionalRanges,
- ProgressShard shard, Route<?> route,
- @Nullable PartialTxn partialTxn,
EnsureAction ensurePartialTxn,
- @Nullable PartialDeps partialDeps,
EnsureAction ensurePartialDeps)
+ private static CommonAttributes set(SaveStatus newStatus, Command cur,
CommonAttributes upd,
Review Comment:
yep, agreed. I think this is better than it was though, and perhaps we can
think about further refinements later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
