michaelsembwever commented on code in PR #3464:
URL: https://github.com/apache/cassandra/pull/3464#discussion_r1711157868
##########
test/unit/org/apache/cassandra/repair/FuzzTestBase.java:
##########
@@ -183,7 +183,9 @@ public static void setUpClass()
UnitConfigOverride.maybeOverrideConfig();
DatabaseDescriptor.daemonInitialization();
-
DatabaseDescriptor.setCommitLogWriteDiskAccessMode(Config.DiskAccessMode.mmap);
+
+ if (DatabaseDescriptor.getCommitLogWriteDiskAccessMode() ==
Config.DiskAccessMode.direct)
Review Comment:
nit: this warrants a comment explaining the limitations this imposes on
testing compression, encryption, etc. particularly because this is a static,
impacting every test running in the same jvm…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
