dcapwell commented on code in PR #3481:
URL: https://github.com/apache/cassandra/pull/3481#discussion_r1720299783
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -532,22 +541,21 @@ else if (!tableId.equals(newTableId))
}
@VisibleForTesting
- static ReadTimeoutException newBarrierTimeout(TxnId txnId, boolean global)
+ static ReadTimeoutException newBarrierTimeout(TxnId txnId, BarrierType
barrierType, boolean isForWrite, Seekables<?, ?> keysOrRanges)
{
- return new ReadTimeoutException(global ? ConsistencyLevel.ANY :
ConsistencyLevel.QUORUM, 0, 0, false, txnId.toString());
+ return new ReadTimeoutException(barrierType.global ?
ConsistencyLevel.ANY : ConsistencyLevel.QUORUM, 0, 0, false,
String.format("Timeout waiting on barrier %s / %s / %s; impacted ranges %s",
txnId, barrierType, isForWrite ? "write" : "not write", keysOrRanges));
Review Comment:
this was a improvement in CASSANDRA-19833 and was easier to keep when I spun
off the debug logic (as its one of the other changes to this class)... I could
split this out if desired
When repair sees these it just logged the txnId, so more detail is just for
repair error messages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
