JeetKunDoug commented on code in PR #132:
URL: https://github.com/apache/cassandra-sidecar/pull/132#discussion_r1729419767
##########
src/main/java/org/apache/cassandra/sidecar/config/yaml/S3ClientConfigurationImpl.java:
##########
@@ -51,26 +68,34 @@ public S3ClientConfigurationImpl()
this(DEFAULT_THREAD_NAME_PREFIX,
DEFAULT_S3_CLIENT_CONCURRENCY,
DEFAULT_THREAD_KEEP_ALIVE_SECONDS,
+ DEFAULT_RANGE_GET_OBJECT_BYTES_SIZE,
+ DEFAULT_API_CALL_TIMEOUT_MILLIS,
new S3ProxyConfigurationImpl());
}
public S3ClientConfigurationImpl(String threadNamePrefix,
int concurrency,
long threadKeepAliveSeconds,
+ int rangeGetObjectBytesSize,
+ long apiCallTimeoutMillis,
S3ProxyConfiguration proxyConfig)
{
+ Preconditions.checkArgument(apiCallTimeoutMillis >
TimeUnit.SECONDS.toMillis(10),
Review Comment:
Why is 10 seconds the minimum? Just an AWS client limitation or ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
