yifan-c commented on code in PR #133: URL: https://github.com/apache/cassandra-sidecar/pull/133#discussion_r1729514657
########## .asf.yaml: ########## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +notifications: + commits: [email protected] + issues: [email protected] + pullrequests: [email protected] + jira_options: link worklog + +github: + description: "Sidecar for Apache Cassandra®" + homepage: https://cassandra.apache.org/ + enabled_merge_buttons: + squash: false Review Comment: Thank you for the timely reply Mick! The "Squash and Merge" option does not produce the meaningless merge commit. Most of the commits made this year are using the "squash and merge" option. It avoids the work to squash locally and force push. The option is effectively the same as squash and rebase. I would like to enable "squash". On a related topic, I want to disable "rebase" option. We never want to have multiple commits from a single patch. With "rebase" option enabled, there is a risk that multiple commits being merged into the mainline w/o paying attention. Let me know if the above is sounding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
