belliottsmith commented on code in PR #108:
URL: https://github.com/apache/cassandra-accord/pull/108#discussion_r1735721145
##########
accord-core/src/main/java/accord/topology/Topology.java:
##########
@@ -60,8 +61,10 @@ public class Topology
{
public static final long EMPTY_EPOCH = 0;
private static final int[] EMPTY_SUBSET = new int[0];
- public static final Topology EMPTY = new Topology(null, EMPTY_EPOCH, new
Shard[0], Ranges.EMPTY, Collections.emptyMap(), Ranges.EMPTY, EMPTY_SUBSET);
+ public static final Topology EMPTY = new Topology(null, EMPTY_EPOCH,
Collections.emptySet(), new Shard[0], Ranges.EMPTY, Collections.emptyMap(),
Ranges.EMPTY, EMPTY_SUBSET);
+
final long epoch;
+ final Set<Id> staleIds;
Review Comment:
This could also quite easily be represented as a bitset per shard (we could
even realistically store it as a single long in cases where we have rf<64, but
probably not worth optimising that far if we can just have a null bitset when
empty)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
