hardikmadhu commented on PR #1810: URL: https://github.com/apache/cassandra-gocql-driver/pull/1810#issuecomment-2336456799
Hi @BenEddy ! Thanks for the work here! I have also been looking to do something similar to log some context. I have a couple of questions, but I'm a total golang noob, so ignore if some of these comments don't make sense. 1. As you elaborate in your description, if the idea is to log some context, configuring driver side rate limiter etc, wouldn't it be a better idea to add the intercept on Attempts? If you're in a real pickle, where you're actually trying to debug something, host timeouts, network issues, server load etc, having an intercept in the attempt would be invaluable. 2. Since the query and batch intercept are almost identical, except the type of query, wouldn't it be possible to define an interface, that could take either query or batch as an argument and we'd be able to decide what intercept to execute after assessing the type? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
