Suhel0328 commented on code in PR #3508:
URL: https://github.com/apache/cassandra/pull/3508#discussion_r1755201566
##########
src/java/org/apache/cassandra/tools/nodetool/GcStats.java:
##########
@@ -19,19 +19,29 @@
import org.apache.cassandra.tools.NodeProbe;
import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
+import org.apache.cassandra.tools.nodetool.stats.*;
import io.airlift.airline.Command;
+import io.airlift.airline.Option;
@Command(name = "gcstats", description = "Print GC Statistics")
public class GcStats extends NodeToolCmd
{
+ @Option(title = "format",
Review Comment:
Since now I have both `json` and `yaml` as options. I've kept the Option
annotation in the multiline format
`@Option(title = "format",
name = {"-F", "--format"},
description = "Output format (json, yaml)")
private String outputFormat = "";`
Does this look good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
