lukasz-antoniak commented on PR #1720: URL: https://github.com/apache/cassandra-java-driver/pull/1720#issuecomment-2345320888
> > Wrapping `after` is not necessary, as follow-up `before` would clean things up. > > it `super().after()` fails, `CURRENT` stays populated and you endup with the exact same problem. It is a valid point. However, tests usually run `ccm start` in before phase and `ccm remove` in after phase. If `ccm remove` fails (or any other exception is thrown by `super.after()`) it would indicate a bug in CCM project, but then potentially running C* node may not have been terminated. Trying to `ccm start` another node could also cause problems and fail for subsequent executions (e.g. TCP port already in use). Based on experience running driver tests on Jenkins, I have never seen `ccm remove` fail. 👍 for attempting to handle failures of `super.after()` and rule chain sequence. To justify merging this PR - it will still greatly reduce situation when single `ccm start` failure causes subsequent tests to fail. `ccm start` failures do not happen often. Currently, when this happens more tests get reported as failed on Jenkins and it is harder to point flaky tests. `ccm start` can indeed be a cause of test failures. A common example is test with old C* / DSE version in the backend that tries to use a feature introduced later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
