worryg0d commented on code in PR #1782:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1782#discussion_r1756567082
##########
frame.go:
##########
@@ -952,6 +955,10 @@ func (f *framer) parsePreparedMetadata() preparedMetadata {
// TODO: deduplicate this from parseMetadata
meta := preparedMetadata{}
+ if f.proto > protoVersion4 {
Review Comment:
I'm sorry for the misunderstanding here. The `id` field in
`preparedMetadata` doesn't represent `<id>` in the specification, but
`result_metadata_id`.
Also, the naming is terrible here, which leads to a big misunderstanding.
I moved parsing of the `result_metadata_id` from this method to the
`parseResultPrepared` method, because the `result_metadata_id` field is a part
of the **PREPARED** message, not its metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
