belliottsmith commented on PR #113: URL: https://github.com/apache/cassandra-accord/pull/113#issuecomment-2350922057
For some reason there's a bunch of questions I missed before that I can't reply to inline, so I will reply here for posterity > Ah I missed the significance of max which is we are just looking for the largest value. I am a little confused how an epoch with > executeAt's epoch could be involved in a transaction? Is this to handle ranges moving around within a node? This logic is generally a bit messy and I will be cleaning it up to make it more obvious in a later commit, but this is just to ensure that any local command store that is requesting the data is actually _provided_ the data. So, whatever information we have is sufficient, it's just calculating the epoch at which a local store might participate. For instance, a future epoch command store may have witnessed an earlier epoch's transaction without knowing whether it will end up executing there - if indeed it does end up _not_ executing there, the later epoch that witnessed it still now needs to know that, else it may hold up execution of any commands that had witnessed the earlier epoch's command. > My original question is still why it's OK to have missing information like route, or additionalKeysOrRanges when calling this method and just take whatever epoch is the executeAt epoch. For the same reason - if the local command store doesn't have that information, it obviously isn't relevant for deciding what epoch that command store might participate in the transaction for (only those keys/routes it knows of matter) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
