belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1764725997
##########
accord-core/src/test/java/accord/impl/basic/Cluster.java:
##########
@@ -475,11 +513,40 @@ public static Map<MessageType, Stats> run(Id[] nodes,
MessageListener messageLis
}, 5L, SECONDS);
Scheduled reconfigure =
sinks.recurring(configRandomizer::maybeUpdateTopology, 1, SECONDS);
+
+ Scheduled purge = sinks.recurring(() -> {
+ trace.debug("Triggering purge.");
Review Comment:
It would be nice to randomise the frequency of these operations (lots of
time in tests is now spent on restart, and anyway would be good to change the
cycle), and also to randomise the set of nodes we shutdown for this, so that
some transactions can carry on being processed (potentially) during this
window, and we can exercise more interesting situations.
Or perhaps just randomise each replica independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
